Feature - remember window bounds on window.show() #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 14, 2024 12:54
opinionated implementation of storing window size and position in appdata using electron-store. personally a hard-requirement for development with any HMR + electron to prevent windows jumping all over the place after every file save
|
This may be a useful feature, but I want to keep this template as less dependencies as possible. So you can re-implement this feature without third-paty dependencies and open new PR. Or, post your showcase into the discussion section. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remembers the window size and position for devmode and production respectively. Uses local user storage like appdata to persist this.
It fixes an important issue for me, which is windows constantly jumping around on every file save, causing frustration, especially on multi-monitor setups.
devmode is seperated from production as many people will keep a different window width when devtools are open.
it is a small QoL feature, but still requires electron-store or similar new util dependancy. I don't know if that is a deal-breaker for your templating philosophy, but i felt like offering the contribution nonetheless.
Thanks for the nice boilerplate.