chore(main): remove declaration of unused variables for docker-autoscaler setup #1223
Conversation
|
Hey @ikarlashov! 👋 Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process. Make sure that this PR clearly explains:
With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE. The following ChatOps commands are supported:
Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command. This message was generated automatically. You are welcome to improve it. |
ikarlashov
changed the title
ikarlashov
changed the title
| max_growth_rate = The maximum number of machines that can be added to the runner in parallel. | ||
| on_demand_base_capacity = Absolute minimum amount of desired capacity that must be fulfilled by on-demand instances. | ||
| on_demand_percentage_above_base_capacity = Percentage split between on-demand and Spot instances above the base on-demand capacity. | ||
| override_instance_types = List to override the instance type in the Launch Template. Allow to spread spot instances on several types, to reduce interruptions | ||
| profile_name = profile_name = Name of the IAM profile to attach to the Runner Workers. |
There was a problem hiding this comment.
issue: as long as we do not change the type definition below, we mustn't remove the description.
suggestion: change the description to (deprecated, not in use) # TODO remove in the upcoming major release or similar.
Signed-off-by: Yevgen Karlashov <[email protected]>
kayman-mk
force-pushed
the
del_unused_vars_docker_autoscaler
branch
from
b03e8db to
f9d3349
Compare
Description
This PR removes the declaration of some settings of
var.runner_worker_docker_autoscaler_asgthat are never used in the terraform manifests of the module.Migrations required
No
Verification
Remove:
max_growth_rateoverride_instance_typesprofile_namefrom
var.runner_worker_docker_autoscaler_asgdeclaration invariables.tf