Skip to content
This repository has been archived by the owner on Jun 2, 2024. It is now read-only.

fix: alt tab menu #209

Merged
merged 1 commit into from
May 27, 2024
Merged

fix: alt tab menu #209

merged 1 commit into from
May 27, 2024

Conversation

nullishamy
Copy link
Contributor

Closes #177

@nullishamy
Copy link
Contributor Author

We still need to figure out what the best approach to upstreaming these patches is. Let's label it for now so we can revisit it in the future.

@nullishamy nullishamy added the upstream:intended These changes are intended to be PRd upstream label May 21, 2024
@isabelroses
Copy link
Member

We still need to figure out what the best approach to upstreaming these patches is. Let's label it for now so we can revisit it in the future.

I think add the patch, such that anyone running the repo from main is happy. Then also upstream the patch, and remove the patch when its merged.

@nullishamy
Copy link
Contributor Author

We still need to figure out what the best approach to upstreaming these patches is. Let's label it for now so we can revisit it in the future.

I think add the patch, such that anyone running the repo from main is happy. Then also upstream the patch, and remove the patch when its merged.

Was my general idea also 👍, let's go with that. Should we make a secondary issue to track the upstream contribution? I don't think we should block our patch PRs on someone contributing it upstream?

@nullishamy nullishamy mentioned this pull request May 21, 2024
Closed
2 tasks
@isabelroses
Copy link
Member

Should we make a secondary issue to track the upstream contribution?

Seems like a good idea to me.

I don't think we should block our patch PRs on someone contributing it upstream?

I assume this means anyone can contribute here or upstream? If so, we should mark PRs that are considered upstream patches and send it up ourselves, that should prevent us blocking PRs to this repo.

@nullishamy
Copy link
Contributor Author

I assume this means anyone can contribute here or upstream? If so, we should mark PRs that are considered upstream patches and send it up ourselves, that should prevent us blocking PRs to this repo.

I don't see why not! If we have the patch files, anyone can submit the PR upstream. Should make some labels to describe this, and have some instructions in the CONTRIBUTING?

@isabelroses
Copy link
Member

I assume this means anyone can contribute here or upstream? If so, we should mark PRs that are considered upstream patches and send it up ourselves, that should prevent us blocking PRs to this repo.

I don't see why not! If we have the patch files, anyone can submit the PR upstream. Should make some labels to describe this, and have some instructions in the CONTRIBUTING?

seems good to me.

@nullishamy nullishamy mentioned this pull request May 22, 2024
Closed
1 task
@nullishamy
Copy link
Contributor Author

Blocked on v1.

@nullishamy nullishamy added blocked priority:medium This is a medium priority issue, and should be looked at promptly. labels May 27, 2024
@sgoudham sgoudham removed the blocked label May 27, 2024
@sgoudham sgoudham merged commit cae57c8 into main May 27, 2024
1 check passed
@sgoudham sgoudham deleted the fix/alt-tab-menu branch May 27, 2024 17:28
@github-actions github-actions bot mentioned this pull request May 27, 2024
Merged
@sgoudham sgoudham mentioned this pull request May 27, 2024
Closed
This was referenced May 27, 2024
Merged
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sgoudham sgoudham sgoudham approved these changes

Assignees
No one assigned
Labels
priority:medium This is a medium priority issue, and should be looked at promptly. upstream:intended These changes are intended to be PRd upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App switcher not fully using theme coloring
3 participants
@nullishamy @isabelroses @sgoudham