Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactivate Plexon 2 tests on Mac arm. #1195

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

h-mayorquin
Copy link
Collaborator

As discussed on #1192.

Let's monitor the test for a couple of merges.

@h-mayorquin h-mayorquin self-assigned this Feb 7, 2025
@h-mayorquin h-mayorquin changed the title reactivate test Reactivate Plexon 2 tests on Mac arm. Feb 7, 2025
@h-mayorquin h-mayorquin marked this pull request as ready for review February 7, 2025 21:58
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.65%. Comparing base (96dfdff) to head (ce9dbd4).
Report is 32 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1195      +/-   ##
==========================================
- Coverage   90.69%   89.65%   -1.05%     
==========================================
  Files         129      129              
  Lines        8189     8378     +189     
==========================================
+ Hits         7427     7511      +84     
- Misses        762      867     +105     
Flag Coverage Δ
unittests 89.65% <ø> (-1.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 20 files with indirect coverage changes

@h-mayorquin
Copy link
Collaborator Author

@pauladkisson seems to be working here : /

Let's look at this across a couple of updates to see if the error re-appears.

@pauladkisson
Copy link
Member

seems to be working here : /

What do you mean? This one is failing: macos-latest Python 3.10

@h-mayorquin
Copy link
Collaborator Author

seems to be working here : /

What do you mean? This one is failing: macos-latest Python 3.10

My bad, I spoke too soon. Ok. So, at least we can track it and fix it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants