Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1D commanded voltage series #19

Merged
merged 1 commit into from
May 20, 2024
Merged

Fix 1D commanded voltage series #19

merged 1 commit into from
May 20, 2024

Conversation

weiglszonja
Copy link
Contributor

Fix #17

@weiglszonja weiglszonja requested a review from pauladkisson May 19, 2024 10:14
@weiglszonja
Copy link
Contributor Author

Can you try @pauladkisson if this fixes your problem with 1D commanded voltage series?

pauladkisson
pauladkisson approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, this does the trick!

@pauladkisson pauladkisson merged commit 8e8e9d4 into main May 20, 2024
33 of 34 checks passed
@pauladkisson pauladkisson deleted the fix_1D_commanded_voltages branch May 20, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauladkisson pauladkisson pauladkisson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CommandedVoltageSeries incorrect shape error for 1D data
2 participants
@weiglszonja @pauladkisson