Add interface for 2p imaging data, suite2p and spike2 signals in dual acquisition modality

[alessandratrapani]

Small PR to add interfaces as in the 2p-only configuration #22

• add interface for 2p data in dual modality (probably just reusing the one for 2p only acquisition)
• add suuite2p interface
• add spike 2 signals
• add correct metadata for dual acquisition
• time alignment

PS: no behavioral video present. Facemap output will be added in a followup PR after solving #19

[alessandratrapani]

stub nwb file here

[weiglszonja]

is it not 1p microscope then?

[alessandratrapani]

Good Catch! NO it should be 1p, I corrected it

[weiglszonja]

The wheel signal here has [100, 1] dimension, while in the other example it was [100], I think it should be [100] here as well, is it not?

[weiglszonja]

The OnePhotonMicroscope is added here, but there is not ImagingPlane linked to it, is it intentional?

[alessandratrapani]

The OnePhotonMicroscope is added here, but there is not ImagingPlane linked to it, is it intentional?

Yes, I created already the complete metadata yaml, I am going to add the one photo series in a next PR

[weiglszonja]

Ok, looks good!

[alessandratrapani]

The wheel signal here has [100, 1] dimension, while in the other example it was [100], I think it should be [100] here as well, is it not?

That's weird, I re-run it and now they both have shape (100,1)

[weiglszonja]

The wheel signal here has [100, 1] dimension, while in the other example it was [100], I think it should be [100] here as well, is it not?

That's weird, I re-run it and now they both have shape (100,1)

Hmm is that from Spike2? But this can also be discussed in a follow-up

[alessandratrapani]

The wheel signal here has [100, 1] dimension, while in the other example it was [100], I think it should be [100] here as well, is it not?

That's weird, I re-run it and now they both have shape (100,1)

In that case I think we should store as (100,) if it's a single trace, but can also discuss in a follow-up

Yes the interface is custom but the extractor is from neuroconv (CedRecordingExtractor)

[weiglszonja]

Yeah I would squeeze the last dimension if this is a single trace. The extractor is from spikeinterface, the interface would be from NeuroConv

Yes, sorry, I meant the interface is ad hoc while the extractor is the CedRecordingExtractor from spikeinterface. So, should I also implement an ad hoc extractor?

[weiglszonja]

Yeah I would squeeze the last dimension if this is a single trace. The extractor is from spikeinterface, the interface would be from NeuroConv

Yes, sorry, I meant the interface is ad hoc while the extractor is the CedRecordingExtractor from spikeinterface. So, should I also implement an ad hoc extractor?

No, you can just edit this line here:

higley-lab-to-nwb/src/higley_lab_to_nwb/lohani_2022/interfaces/lohani_2022_spike2signals_interface.py

Line 133 in ede7e66

data=extractor.get_traces(end_frame=end_frame),

[alessandratrapani]

No, you can just edit this line here:

higley-lab-to-nwb/src/higley_lab_to_nwb/lohani_2022/interfaces/lohani_2022_spike2signals_interface.py

Line 133 in ede7e66

data=extractor.get_traces(end_frame=end_frame),

Ah yes, thanks! I will do it here #23 since this affect both conversions

[weiglszonja]

okok, good to go then