S3 path style endpoint setting#716
Open
Frostist wants to merge 7 commits intocatalyst:MOODLE_404_STABLEfrom
Open
S3 path style endpoint setting#716Frostist wants to merge 7 commits intocatalyst:MOODLE_404_STABLEfrom
Frostist wants to merge 7 commits intocatalyst:MOODLE_404_STABLEfrom
Conversation
Was missing a )
Added support for path-style endpoint configuration in S3 client.
Added settings for AWS path style endpoint configuration.
Contributor
Author
|
I have merged current updates here @danmarsden and @fDougelseSa |
natjw
suggested changes
Apr 15, 2026
natjw
left a comment
natjw
left a comment
There was a problem hiding this comment.
Like I said in my answer in my PR, there are 3 more things for this to work for me.
- Is the thing mentioned in the review, the option is broken the way you hardcode it to
true. - We need to catch another exception in case of error. See https://github.com/natjw/moodle-tool_objectfs/blob/74a69f015bfe6e565d531fd584bbdebef97b4fdc/classes/local/store/s3/client.php#L337-L340
- We need to prevent the AWS SDK from using the IMS in case of not running on AWS. See https://github.com/natjw/moodle-tool_objectfs/blob/74a69f015bfe6e565d531fd584bbdebef97b4fdc/classes/local/store/s3/client.php#L821-L827
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I edited the code in a newer version of the repo in order to merge it now, see my past pull request here:
#670