Castle.Services.Logging.EventLogIntegration for Windows EventLog #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
master
branch
9 times, most recently
from
90fc013 to
e2d3359
Compare
snakefoot
changed the title
snakefoot
force-pushed
the
master
branch
5 times, most recently
from
e4f9c96 to
bf66485
Compare
snakefoot
changed the title
snakefoot
force-pushed
the
master
branch
3 times, most recently
from
42a4a04 to
a05e9c2
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed nuget-dependency
System.Diagnostics.EventLogfrom the Castle.Core-package as it is Windows-only (And will explode in your face when used on other platforms).Makes Castle.Core free of extra nuget-dependencies for
net462+netstandard2.1+net6.0(essence of core)People using Windows and depend on the
DiagnosticsLoggerjust have to add an additional nuget-package to their project.Could consider changing
net6.0tonet6.0-windowsforCastle.Services.Logging.EventlogIntegrationand remove the direct nuget-dependency.