Transfers - extra session args #93
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After discussion with @Fraser999 - we want to add support also for JSONs args - so I will add a new parser that supports both JSON and simple-args rather than calling manually Also we want to get rid of args-complex - listed here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now it only supports
--session-arglike mentioned in a ticket.I would consider supporting also JSON or complex args but was not sure about this - that's why for now I made
parse::arg_simple::getpublic and use it innew_transfermethod. If we would like to support all of the types then I can add different layer of abstraction dedicated to extendingTransferargs.