Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WeatherXds: make STATION_POSITION required, remove antenna_name #373

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

FedeMPouzols
Copy link
Collaborator

Resolves #335, Fixes #365.


Note well:

This contribution is made under the current ALMA software agreements. 
(c) European Southern Observatory, 2024, 2025
Copyright by ESO (in the framework of the ALMA collaboration)

@FedeMPouzols FedeMPouzols linked an issue Mar 14, 2025 that may be closed by this pull request
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

antenna_position data var from the antenna_xds (expected to still including the initial ANTENNA_ID
coordinate as wellas other coordinates from the antenna_xds)
has_asdm_station_position : bool
wHether this generic weatehr_xds should be treated as including the nonstandard extensions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether?

station name data array from antenna_xds, with name/id information
ant_position_with_ids : xr.DataArray
antenna_position data var from the antenna_xds (expected to still including the initial ANTENNA_ID coordinate
as wellas other coordinates from the antenna_xds)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well as?

@kettenis
Copy link
Contributor

The schema changes mean that there no longer is a direct link between antennas and weather stations. So code that wants to do antenna-based corrections based on weather data will need to use some sort of heuristic to find the relevant weaither data. I suppose the default heuristic would be to use the closest station. Potential issue with that approach is that if weather data is only provided for a subset of (VLBI) antennas we'll need to apply some sort of cutoff to make sure we don't use data that is totally irrelevant for an antenna.

Hard to come up with something better though if we want to support both the case where a single weather stations provides information for multiple antennas and the case where multiple weather stations provide information for a single antenna.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No weather_xds ALMA WeatherXds: STATION_POSITION WeatherXds: time_weather
3 participants