-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Microsoft Defender for Endpoint source #1009
base: master
Are you sure you want to change the base?
Conversation
This reverts commit 32a94ae.
I think this is good for review and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try to avoid pandas. We can use a similar transform approach as in this PR: #1146, happy to continue helping here.
It might also be worth exploring using the data model using that PR as example.
@@ -56,6 +56,7 @@ | |||
"kubernetes>=22.6.0", | |||
"pdpyras>=4.3.0", | |||
"crowdstrike-falconpy>=0.5.1", | |||
"pandas>=1.5.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pandas is a very heavy dependency. Can we do without it?
@@ -6,6 +6,7 @@ on: | |||
push: | |||
branches: | |||
- master | |||
- devel* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this do? Can we omit it?
""" | ||
cartography/intel/mde/endpoints | ||
""" | ||
# pylint: disable=missing-function-docstring,too-many-arguments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# pylint: disable=missing-function-docstring,too-many-arguments |
|
||
Placeholder representation of a single [MDE Host or machine](https://docs.microsoft.com/en-us/microsoft-365/security/defender-endpoint/get-machines?view=o365-worldwide). This node is the minimal data necessary to map an asset. | ||
|
||
Warning! Work In Progress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning! Work In Progress. |
I will try to review but I don't think it will be in near time. |
Add Ingestion of MDE assets as source (follow-up of #999)
Include initial test data and draft schema
Bugs
Pending
Reviewed with pylint and black