Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spooky patch #74

Merged
merged 23 commits into from
Sep 19, 2024
Merged

Spooky patch #74

merged 23 commits into from
Sep 19, 2024

Conversation

DavideCristoni
Copy link
Contributor

Added all the courses form Computer science Master that were not already in the list

@DavideCristoni
Copy link
Contributor Author

I'm about to faint

@foxyseta
Copy link
Member

@DavideCristoni need help with the conflicts? Is there a reason why this is not part of #73?

I'll wait for this to be merged before tagging a new release so that the Go projects using this dependency can update it, too.

@DavideCristoni
Copy link
Contributor Author

Sorry about all the errors! I must have rushed it a little too much! Gonna fix them now.

@DavideCristoni
Copy link
Contributor Author

@DavideCristoni need help with the conflicts? Is there a reason why this is not part of #73?

I'll wait for this to be merged before tagging a new release so that the Go projects using this dependency can update it, too.

This is not part of #73 because it was merged and I wanted to do a little pr first just to get the hand of it. If that is a problem, next time I'll finish the job first. Thinking about that, maybe it's better if I finish adding the courses of also curricula B and C before the final approval.

@foxyseta foxyseta marked this pull request as draft September 19, 2024 12:18
@foxyseta
Copy link
Member

No problem at all! Just wanted to make sure you didn't need any extra help.

I marked this PR as a draft for now, so that people don't accidentally merge it. Once you feel confident in your work, you can just click on "Ready for review".

@DavideCristoni DavideCristoni marked this pull request as ready for review September 19, 2024 14:57
@DavideCristoni
Copy link
Contributor Author

I added all the remaining teachings, correctly marked if they are mandatory or not (but not separated them by year because it is a gray area as people from the 1st year can add exams from the second anyway). I hope everything is good to go.

@gabrielegenovese gabrielegenovese merged commit a5b51bf into main Sep 19, 2024
2 checks passed
@foxyseta
Copy link
Member

Okay, I'll make a new tag now.

@ali-benny ali-benny deleted the spooky-patch branch September 19, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants