V1.3.0 - Configuration Overhaul #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix test_forge_main_errors Fix test_forge_main Remove test_yaml_loader.py Remove todo Fix start tests Fix ssh tests Fix test input data Fix run tests Fix rsync tests Optimize common tests Fix destroy tests Fix create tests Fix common tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completely overhauls the configuration system that we were using before. Rather than utilizing python schemas in a messy and overcomplicated manner to get data validation, we instead now use dataclasses to get type checking and data validation at creation of the configuration, while still allowing updates and modifications to be made in the meantime. This maintains complete backwards compatibility with prior versions of Forge except for the
configure.pyfile, which needs to be reworked.