dnf clean after dnf install in Dockerfiles
#948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch has no changes to coverable lines. ❗ Your organization needs to install the Codecov GitHub app to enable full functionality. 📢 Thoughts on this report? Let us know!. |
|
Thanks for these changes. It's worth noting that there are test build environments only (for unit tests). So there isn't a huge gain from your great finds. Shrink this docker container and we've got more of a rewarding outcome |
caronc
reviewed
Sep 10, 2023
| @@ -48,13 +48,15 @@ RUN ( \ | |||
| dnf install -y rpm-build rpmlint python3-pip python3-virtualenv rubygem-ronn \ | |||
| dnf-plugins-core 'dnf-command(config-manager)' \ | |||
| 'dnf-command(builddep)' sudo rsync rpmdevtools; \ | |||
| dnf config-manager --set-enabled powertools; | |||
| dnf config-manager --set-enabled powertools; \ | |||
| dnf clean all; | |||
There was a problem hiding this comment.
This clean all is not needed, it slows down the second dnf install below
There was a problem hiding this comment.
It could be! Depends on the network environment and the upstream server being used.
The better way may be to merge those installs, so that the process will be fast, and the image will be slow?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that
dnfdoesn't leave unnecessary temporary files in the Docker images, thereby reducing their size.Regarding the change in image size, it seems there isn't much difference for the rawhide and f39 builds. However, the f38 and el8 builds have shown significant improvement.
For the image size changes, see the result below.
Before:
After: