converted .size() to .length #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.size() has been deprecated and this script fails to update the cart quantity after adding product to cart. Really needed since this is used on the official shopify documentation. https://help.shopify.com/en/themes/customization/products/add-to-cart/stay-on-product-page-when-items-added-to-cart
|
.size() calls function { .length }. .length is the preferred method, faster and one less method call. Also deprecated in new versions. And lastly should be backward compatible in past jquery. |
|
Ran into the exact same issue just now and came to make this exact pull request, lol. |
|
Same here. Spent a few hours coming to this solution only to discover it's an unmerged PR. Thanks for providing it anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.size() has been deprecated and this script fails to update the cart quantity after adding product to cart. Really needed since this is used on the official shopify documentation.
https://help.shopify.com/en/themes/customization/products/add-to-cart/stay-on-product-page-when-items-added-to-cart