QueryArrayWidget does not work with the foo=bar,baz syntax #1685 #1686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What should I do to get this merged in? |
tests/test_widgets.py
Outdated
| @@ -526,11 +527,14 @@ def test_widget(self): | |||
| <input type="text" name="price" value="1,2" />""", | |||
| ) | |||
|
|
|||
| import django.http | |||
| @@ -595,3 +599,7 @@ def test_widget_value_from_datadict(self): | |||
|
|
|||
| result = w.value_from_datadict({}, {}, "price") | |||
| self.assertEqual(result, []) | |||
|
|
|||
| data = QueryDict("price=1,2") | |||
There was a problem hiding this comment.
This isn't a query array example. 🤔
There was a problem hiding this comment.
The idea is that all input would work, not just QueryArrays. Also ?price=1,2. QueryArray only supports ?price=1,price=2.
|
Thanks for the review! Will update the PR. The reason for this PR is that:
This makes it hard for the frontend to know when to use which and also the frontend like to use ?a=x,y also for the ModelMultipleChoiceFilter. With this fixes, you can in both cases use a QueryArrayWidget and all three search filters, for all types of filtering that uses multiple entries (whether __in or ModelMultipleChoiceFilter):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the failing test.