Refactor signTx
#4128
Draft
Refactor signTx
#4128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
commented
Sep 19, 2023
| $ Cardano.InAnyCardanoEra era | ||
| $ Write.toCardanoTx | ||
| $ f eraForSigning | ||
| $ Write.fromCardanoTx ctx |
There was a problem hiding this comment.
Should possibly take a value level RecentEra era instead of the constraint
Anviking
commented
Sep 21, 2023
Comment on lines
+338
to
+344
| -- FIXME: HACK because shared wallets have 'ScriptHash -> addrXPrv' lookup, | ||
| -- not 'KeyHash -> addrXPrv' lookup. | ||
| timelockHashes = Set.fromList $ map (fromCAScriptHash . CA.toScriptHash) timelockScripts | ||
| where | ||
| fromCAScriptHash = fromMaybe err . keyHashFromBytes . CA.unScriptHash | ||
| where | ||
| err = error "fromCAKeyHash invalid hash" |
There was a problem hiding this comment.
Probably we can just add a separate resolver without downside
Problem is that 'mkExtraWitness' isn't signed by keyLookup anymore.
mkExtraWitness :: Cardano.Hash Cardano.PaymentKey -> Maybe (Cardano.KeyWitness era)
mkExtraWitness vkh = do
-- NOTE: We cannot resolve key hashes directly, so create a one-time
-- temporary address with that key hash which is fine to lookup via the
-- address lookup provided above. It works _fine_ because the discovery
-- of addresses is done properly based on the address constituents (i.e.
-- the key hash) and not the overall address itself.
let addr = Cardano.makeShelleyAddress networkId
(Cardano.PaymentCredentialByKey vkh)
Cardano.NoStakeAddress
This reverts commit f503e1a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redefine-> NOisOursfor SeqState takingKeyFingerprintinstead (basically aKeyHash)estimateKeyWitnessCountTRANS_NEW_ASSETS_CREATE_02 - using reference scriptComments
Issue Number
ADP-2675