Experimental: Revise flawed expectations about fee estimation in integration tests. #3832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanknowles
force-pushed
the
jonathanknowles/revise-flawed-fee-estimation-expectations
branch
from
fd5deb9
to
d5dddb6
Compare
The integration test suite is arguably the wrong place to test that fee estimates should increase or decrease if the outputs of a transaction are changed. Moreover, depending on the initial starting conditions and the random selection performed for each round of fee estimation, it's not guaranteed that if the outputs for transaction `a` are smaller than the outputs for transaction `b`, then the fee estimate for transaction `a` will be lower than the fee estimate for transaction `b`.
jonathanknowles
force-pushed
the
jonathanknowles/revise-flawed-fee-estimation-expectations
branch
from
d5dddb6
to
a0e4ff0
Compare
jonathanknowles
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments
Issue Number