Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change derivation path JSON serialization to be less verbose #2209

Closed
wants to merge 1 commit into from
Closed

change derivation path JSON serialization to be less verbose #2209

wants to merge 1 commit into from
+247 −716

Conversation

KtorZ
Copy link
Member

@KtorZ KtorZ commented Oct 5, 2020

Issue Number

#2174

Overview

  • I have changed change derivation path JSON serialization to be less verbose and also aligned with other interfaces like cardano-addresses.

Comments

@KtorZ KtorZ added the ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG label Oct 5, 2020
@KtorZ KtorZ self-assigned this Oct 5, 2020
@KtorZ
change derivation path JSON serialization to be less verbose
ac4222e 
  And also aligned with other interfaces like cardano-addresses.
@KtorZ KtorZ force-pushed the KtorZ/2174/simplify-JSON-derivation-path branch 2 times, most recently from bc406dd to ac4222e Compare October 6, 2020 18:27
@KtorZ
Copy link
Member Author

KtorZ commented Oct 8, 2020

included in #2219

@KtorZ KtorZ closed this Oct 8, 2020
@KtorZ KtorZ deleted the KtorZ/2174/simplify-JSON-derivation-path branch November 16, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paweljakubas paweljakubas Awaiting requested review from paweljakubas

@jonathanknowles jonathanknowles Awaiting requested review from jonathanknowles

Assignees

@KtorZ KtorZ

Labels
ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG
Projects
None yet
Milestone
(ADP-441) Extend Coin Selection with ...
Development

Successfully merging this pull request may close these issues.
2 participants
@KtorZ @rvl