preprocess to ignore styles and handle typescript #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metonym
approved these changes
Jun 17, 2021
|
Published to NPM in v0.8.0 |
|
Thanks for the quick turnaround. It's much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to address #12 and #24. To avoid errors by the svelte compiler, this will preprocess the code to handle typescript and strip away any style blocks since they are not necessary.
Initially, I considered passing in an array of preprocessors as one of the sveld options. But that didn't seem right as the end user should not have to know the internal workings of sveld. Keeping all the logic within sveld seems to make more sense.
I would appreciate any feedback or alternative approaches. We have a component library that we'd like to convert to typescript and is dependent on this working. Thanks!