feat: add experimental Popover to ToolbarButton
#1469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
November 2, 2021 11:57
|
✔️ Deploy Preview for ibm-cloud-cognitive ready! 🔨 Explore the source changes: 68152be 🔍 Inspect the deploy log: https://app.netlify.com/sites/ibm-cloud-cognitive/deploys/61a506bd348a89000856bfe2 😎 Browse the preview: https://deploy-preview-1469--ibm-cloud-cognitive.netlify.app |
dcwarwick
reviewed
Nov 22, 2021
packages/cloud-cognitive/src/components/Toolbar/ToolbarButton.js
Outdated
Show resolved
Hide resolved
SimonFinney
changed the title
Popover to ToolbarButtonPopover to ToolbarButton
…gnitive into toolbar-popover
This was referenced Jan 4, 2022
lee-chase
added
status: depends on issue
and removed
status: blocked 🧱
status: depends on issue
labels
|
@SimonFinney what's the status with this? |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Closing for now as there is not currently a way to import the Popover styles in Carbon v10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #817 — blocked pending
@carbon/stylesmigration.Add experimental
PopovertoToolbarButtoncaret variant logic, stories, styles, and tests.