Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(IdeDataTable): support the useZebraStyles prop #1330

Merged
merged 7 commits into from
Oct 14, 2021
Merged

Feat(IdeDataTable): support the useZebraStyles prop #1330

merged 7 commits into from
Oct 14, 2021

Conversation

s100
Copy link
Contributor

@s100 s100 commented Oct 13, 2021

Contributes to #1224.

What did you change?

  • Add new prop useZebraStyles to <IdeDataTable>. This prop is passed through to the underlying Carbon <DataTable>, identically to how the size prop is passed.
  • Unit test added.
  • Documentation.

How did you test and verify your work?

  • The same way that the size prop was tested. I also tested these changes manually in my local installation of @carbon/ibm-cloud-cognitive-cdai.

@s100 s100 requested a review from a team as a code owner October 13, 2021 11:26
@netlify
Copy link

netlify bot commented Oct 13, 2021

✔️ Deploy Preview for ibm-cloud-cognitive ready!

🔨 Explore the source changes: 321e4be

🔍 Inspect the deploy log: https://app.netlify.com/sites/ibm-cloud-cognitive/deploys/616855fdd640080007f8e51b

😎 Browse the preview: https://deploy-preview-1330--ibm-cloud-cognitive.netlify.app/

Copy link
Contributor

@dcwarwick dcwarwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good -- thanks @s100 for this. This change adds function without affecting any current users, so I'll merge it and push as release.

@dcwarwick dcwarwick changed the title <IdeDataTable> now supports the useZebraStyles prop Feat(IdeDataTable): support the useZebraStyles prop Oct 14, 2021
@kodiakhq kodiakhq bot merged commit 7786624 into carbon-design-system:main Oct 14, 2021
@s100 s100 deleted the patch-1 branch October 14, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants