Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toolbar): add vertical variant #1173

Merged

Conversation

SimonFinney
Copy link
Contributor

Affected issues

Proposed changes

  • Add toolbar vertical variant logic, stories, styles, and test
  • Update default toolbar story to better reflect guidance
  • Refactor common toolbar tests to better accommodate individual component tests

@SimonFinney SimonFinney requested a review from a team as a code owner August 19, 2021 11:36
@netlify
Copy link

netlify bot commented Aug 19, 2021

❌ Deploy Preview for ibm-cloud-cognitive failed.

🔨 Explore the source changes: 380ae45

🔍 Inspect the deploy log: https://app.netlify.com/sites/ibm-cloud-cognitive/deploys/611e423726cecb0007a358c6

@netlify
Copy link

netlify bot commented Aug 19, 2021

✔️ Deploy Preview for ibm-cloud-cognitive ready!

🔨 Explore the source changes: 98438e2

🔍 Inspect the deploy log: https://app.netlify.com/sites/ibm-cloud-cognitive/deploys/612647f76ba45f0008ccde12

😎 Browse the preview: https://deploy-preview-1173--ibm-cloud-cognitive.netlify.app

@matthewgallo
Copy link
Member

https://user-images.githubusercontent.com/10215203/130460308-af865b1d-ed6c-4840-96d0-a49abc9c2549.mov
For the vertical toolbar, it might be easier to use if the tooltip has the option to be placed from the left or right. You cannot easily hover over the item above the current toolbar item because the tooltip is on top of it.

@SimonFinney
Copy link
Contributor Author

SimonFinney commented Aug 25, 2021

https://user-images.githubusercontent.com/10215203/130460308-af865b1d-ed6c-4840-96d0-a49abc9c2549.mov
For the vertical toolbar, it might be easier to use if the tooltip has the option to be placed from the left or right. You cannot easily hover over the item above the current toolbar item because the tooltip is on top of it.

@matthewgallo a quick update on this — the design recommendation is that the default tooltip position should be top for both orientations. I've created an issue and reduced test case in Carbon to investigate further, as it feels like a defect that may not affect just us.

@kodiakhq kodiakhq bot merged commit 574a2c5 into carbon-design-system:main Aug 25, 2021
@SimonFinney SimonFinney deleted the 806/toolbar-orientation branch August 25, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toolbar — orientation
3 participants