feat(toolbar): add Toolbar, ToolbarButton, and ToolbarGroup components
#1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonFinney
changed the title
Toolbar, ToolbarButton, and ToolbarGroup components
|
✔️ Deploy Preview for ibm-cloud-cognitive ready! 🔨 Explore the source changes: 7955f8b 🔍 Inspect the deploy log: https://app.netlify.com/sites/ibm-cloud-cognitive/deploys/611bd8e898b11400073f910c 😎 Browse the preview: https://deploy-preview-1103--ibm-cloud-cognitive.netlify.app/ |
There was a problem hiding this comment.
Looks easy to consume and use @SimonFinney . I like the composition model
added 13 commits
August 4, 2021 21:23
SimonFinney
changed the title
Toolbar, ToolbarButton, and ToolbarGroup componentsToolbar, ToolbarButton, and ToolbarGroup components
lee-chase
reviewed
Aug 12, 2021
|
LGTM. We can discuss the API as we progress toward review, but for a component that needs to hold a variety of different controls by design this looks like a pretty good and straightforward approach to me. |
dcwarwick
previously approved these changes
Aug 12, 2021
dcwarwick
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected issues
Proposed change
Add initial
Toolbar,ToolbarButton, andToolbarGroupdocumentation, logic, tests, styles, and stories.