-
Notifications
You must be signed in to change notification settings - Fork 1.9k
chore(fonts): revert previous fix, unquote unicode-range and font-display values only #19588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(fonts): revert previous fix, unquote unicode-range and font-display values only #19588
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19588 +/- ##
=======================================
Coverage 84.65% 84.65%
=======================================
Files 373 373
Lines 14715 14715
Branches 4846 4848 +2
=======================================
Hits 12457 12457
+ Misses 2108 2107 -1
- Partials 150 151 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @petersandor, could you please remove the @use 'sass:string'
import if it's no longer being used? I believe it was added in the previous PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍 Thanks again for this revision!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes
624890b
Partially reverts #19511
Changelog
Changed
unicode-range
andfont-display
values by defaultTesting / Reviewing
unicode-range
andfont-display
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
[ ] Updated documentation and storybook examples[ ] Wrote passing tests that cover this change[ ] Addressed any impact on accessibility (a11y)More details can be found in the pull request guide