Skip to content

chore(fonts): revert previous fix, unquote unicode-range and font-display values only #19588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

petersandor
Copy link
Contributor

Partially reverts #19511

Changelog

Changed

  • use unquoted unicode-range and font-display values by default

Testing / Reviewing

  1. Start any Carbon sample page with the styles loaded (fonts included) in Firefox
  2. Open developer tools and toggle CSS logging
  3. Check for console messages mentioning unknown descriptor in unicode-range and font-display

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • [ ] Updated documentation and storybook examples
  • [ ] Wrote passing tests that cover this change
  • [ ] Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

Copy link

netlify bot commented Jun 7, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bbc9757
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/684712ab4ac78b0008eee18f
😎 Deploy Preview https://deploy-preview-19588--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Jun 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.65%. Comparing base (639bce3) to head (bbc9757).
Report is 23 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19588   +/-   ##
=======================================
  Coverage   84.65%   84.65%           
=======================================
  Files         373      373           
  Lines       14715    14715           
  Branches     4846     4848    +2     
=======================================
  Hits        12457    12457           
+ Misses       2108     2107    -1     
- Partials      150      151    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@preetibansalui preetibansalui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @petersandor, could you please remove the @use 'sass:string' import if it's no longer being used? I believe it was added in the previous PR.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 Thanks again for this revision!

Copy link
Contributor

@preetibansalui preetibansalui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes

@preetibansalui preetibansalui added this pull request to the merge queue Jun 11, 2025
Merged via the queue into carbon-design-system:main with commit 624890b Jun 11, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants