[a11y] ExpandableSearch has unnecessary aria-label="button" #19532
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19532 +/- ##
==========================================
- Coverage 84.48% 84.48% -0.01%
==========================================
Files 373 373
Lines 14645 14644 -1
Branches 4840 4789 -51
==========================================
- Hits 12373 12372 -1
Misses 2125 2125
Partials 147 147 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2nikhiltom
approved these changes
Jun 2, 2025
Gururajj77
approved these changes
Jun 2, 2025
maradwan26
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: one more review 👀
labels
Merged
via the queue into
carbon-design-system:main
with commit Jun 2, 2025
746cb92
37 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19516
This documentation states: "Don't use both on the same element because
aria-labelledbywill take precedence over aria-label if both are applied." Therefore, I have removed thearia-labeland keptaria-labelledbysincearia-labelis redundant.Changelog
New
Changed
Removed
Testing / Reviewing