Skip to content

React|WC Parity: Multi-select #19502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

maradwan26
Copy link
Contributor

Closes #18336

Added stories, fixed bugs and styling, and added a select-all feature

  • See parent issue for baseline criteria
  • Add "controlled" API for both
  • It looks like the AI Label is missing the gradient style

Changelog

New

  • Added isSelectAll and indeterminate props to multi-select-item for the select all feature
  • Added selectAll prop to multi-select to allow rendering for a select all item
  • Added select all feature to Overview story
  • Added styling for select all item
  • Added stories for Controlled, Select All, With Toggletip Label, Select All With Dynamic Items
  • Added select all handling logic in _selectionDidChange
  • Added select all handling logic so that the select all item is always at the top of the page and never filtered out
  • Added firstUpdated() handling so that the indeterminate state of a select all item is updated whenever new items are added to the list

Changed

  • Fixed AI-Label gradient styling (due to inheritance, this also fixed the gradient for Dropdown and Combobox)
  • Changed multi-select-item rendering so that it uses a cds-checkbox instead of span
  • Fixed styling for disabled items
  • Fixed a bug where items inside slots for multi-select were not being rendered

Removed

Nothing removed

Testing / Reviewing

  • Ensure there is no regression
  • Ensure CI passes
  • Check the following stories in the Deploy Preview:
    • Controlled
    • Select All
    • Select All with Dynamic Items
    • With Toggletip Label
  • Ensure behaviour of Select All (as well as previous features) works as expected

Copy link

netlify bot commented May 28, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 6abeb68
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/683759489450950008c2049b
😎 Deploy Preview https://deploy-preview-19502--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented May 28, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6abeb68
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/68375948ca05aa00097b3ef5
😎 Deploy Preview https://deploy-preview-19502--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.48%. Comparing base (5581a0e) to head (6abeb68).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19502   +/-   ##
=======================================
  Coverage   84.48%   84.48%           
=======================================
  Files         373      373           
  Lines       14641    14641           
  Branches     4839     4787   -52     
=======================================
  Hits        12369    12369           
- Misses       2124     2125    +1     
+ Partials      148      147    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React|WC Parity: Multi-select & Filterable Multiselect
1 participant