fix(DefinitionTooltip): make screen reader announce definition on hover #19482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use aria-describedby for DefinitionTooltip just like Tooltip, to link the term to its definition. Addresses the problem that JAWS doesn't announce the definition when the tooltip is opened, at least when opened by hover (openOnHover === true) rather than clicking. Fixes carbon-design-system#19285
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19482 +/- ##
=======================================
Coverage 84.91% 84.91%
=======================================
Files 373 373
Lines 14504 14504
Branches 4794 4798 +4
=======================================
Hits 12316 12316
Misses 2040 2040
Partials 148 148 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
preetibansalui
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19285
Make
DefinitionTooltiplink the term to its definition viaaria-describedby, just likeTooltipdoes.Addresses the problem that JAWS doesn't announce the definition when the tooltip is opened, at least when opened by hover (
openOnHover === true) rather than clicking.Changelog
New
aria-describedbyattribute forDefinitionTooltip, to link the term to its definition.Testing / Reviewing
Storybook under JAWS. Tested DefinitionTooltip story in main/ vs. DefinitionTooltip story in this PR.
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request guide