chore(Table): remove tabindex setting code #19414
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We know longer need to set tabindex on scrollable nodes, even if they don't contain any interactive content. So remove the complicated Table code that tries to do that. You can test this on http://localhost:3000/?path=/story/components-datatable-basic--default. If you make your browser narrow enough, the table gets a horizontal scrollbar, and you can tab to it. See carbon-design-system/ibm-products#7043 (comment). Refs carbon-design-system#7043.
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19414 +/- ##
==========================================
- Coverage 84.85% 84.84% -0.01%
==========================================
Files 371 371
Lines 14412 14400 -12
Branches 4746 4744 -2
==========================================
- Hits 12229 12218 -11
+ Misses 2036 2035 -1
Partials 147 147 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I'll mark this as a draft though until there's an official decision on what Carbon wants to do. I filed IBMa/equal-access#2281 to talk about removing the requirement from accessibility-checker, and then we can decide on Carbon after that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs IBMa/equal-access#2281.
As Chrome and Firefox now both support keyboard scrolling on divs, we no longer need to set tabindex on scrollable nodes, even if they don't contain any interactive content.
So remove the complicated
Tablecode that tries to do that.See carbon-design-system/ibm-products#7043 (comment).
Changelog
Removed
Testing / Reviewing
You can test this on
http://localhost:3000/?path=/story/components-datatable-basic--default. If you make your browser narrow enough, the table gets a horizontal scrollbar, and you can tab to it.
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request guide