Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multiselect): add local onchangedata for typing #16440

Merged
merged 1 commit into from May 13, 2024

Conversation

ggdawson
Copy link
Contributor

@ggdawson ggdawson commented May 10, 2024

Closes #16433

{{short description}}

Changelog

New

  • n/a

Changed

    • MutliSelect OnChangeData type

Removed

  • n/a

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

Copy link

netlify bot commented May 10, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 96b7bf5
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6642240964ebf00008f725df
😎 Deploy Preview https://deploy-preview-16440--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@guidari
Copy link
Contributor

guidari commented May 13, 2024

Hey @ggdawson I just checked here in a typescript file and ir works fine this solution. You can open the PR

@ggdawson ggdawson marked this pull request as ready for review May 13, 2024 14:30
@ggdawson ggdawson requested a review from a team as a code owner May 13, 2024 14:30
@guidari guidari added this pull request to the merge queue May 13, 2024
Merged via the queue into carbon-design-system:main with commit a96f67e May 13, 2024
20 checks passed
@ggdawson ggdawson deleted the multiselect-onchange branch May 13, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Multiselect typings are incorrect for onchange event
3 participants