New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Tag Overflow #16437
New Tag Overflow #16437
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good @guidari ! Just a couple things below and then it should be good to go! Thank you for all of your patience and help with this work! ⭐️
Tag (stable)
Read only story
- The red tag that is truncated does not have the correct text color. The color should be
$tag-color-red
. The text is also sitting too high in the container, it should be vertically center. (This looks like a Firefox bug specifically.) - The cursor should be the arrow and not the pointer. I am also not seeing the browser based tooltip on hover in Chrome and Firefox. It appears in Safari.
Tag (unstable)
Dismissible story
- When hovering over the text in the tag, the cursor should be an arrow. It only should turn to a pointer cursor when it hovers over the close icon area.
- Disabled state: The truncated tags border gets removed, it should still be present in the disabled state like the other tags.
- Disabled state: Parts of the tag in the first interactive example is still interactive but should not be.
Operational story
- The browser tooltip text says “aaa” but it should say the full title of the tag.
Selectable story
- Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you @guidari ⭐️
This is looking great, just seeing some weirdness when you click on Operational or Selectable Tags with the tooltip flashing. Screen.Recording.2024-05-16.at.8.52.29.AM.mov |
96524a7
Hey there! v11.58.0 was just released that references this issue/PR. |
Closes #15893
This reference the old PR
This PR will add the ellipses to tags that have a long text. When the ellipses is active the Tooltip will added so the user can read the whole tag.
The logic to use the
text
prop in the primitive component couldn't be applied here because of the difference between the way theTooltip
would be displayed in the Dismissable and ReadOnly Tags.Changelog
New
max-inline-size
to tags of 208px.text
to Interactive tags. It will avoid the user to add achildren
inside the InteractiveTag.DefinitionTooltip
and the rest of the tags are usingTooltip
Removed
children
prop from interactive tags.Testing / Reviewing
text
make sense