Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: using ReactNode instead of ReactNodeLike in typescript interfaces #16428

Merged

Conversation

Gururajj77
Copy link
Contributor

Main issue #16054

Closes #16417 - DismissableTag
Closes #16419 - OperationalTag
Closes #16420 - SelectableTag
Closes #16421 - Tag
Closes #16422 - Text
Closes #16423 - TextArea
Closes #16424 - PasswordInput
Closes #16425 - TextInput
Closes #16426 - Tile
Closes #16427 - TileGroup

Changed the usage of ReactNodeLike from Prop-Types library to ReactNode from React in typescript interfaces

Changelog

Changed

  • Changed from ReactNodeLike to ReactNode

Testing / Reviewing

No new testing observations, please check that the functionality is intact or not.

Copy link

netlify bot commented May 10, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 683ff3d
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/663df4a1fc1af50008e17149
😎 Deploy Preview https://deploy-preview-16428--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@2nikhiltom 2nikhiltom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@guidari guidari added this pull request to the merge queue May 14, 2024
Merged via the queue into carbon-design-system:main with commit f0d89db May 14, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants