Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: using ReactNode instead of ReactNodeLike #16418

Merged

Conversation

Gururajj77
Copy link
Contributor

Main issue #16054

Closes #16410 - NumberInput
Closes #16411 - RadioButton
Closes #16412 - RadioButtonGroup
Closes #16414 - Select
Closes #16416 - Slider

Changed the usage of ReactNodeLike from Prop-Types library to ReactNode from React in typescript interfaces

Changelog

Changed

  • Changed from ReactNodeLike to ReactNode

Testing / Reviewing

No new testing observations, please check that the functionality is intact or not.

Copy link

netlify bot commented May 10, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a6c6e84
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6641d62500e3a10008c33bab
😎 Deploy Preview https://deploy-preview-16418--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Gururajj77 Gururajj77 changed the title refactor: using reactnode instead of reactnodelike refactor: using ReactNode instead of ReactNodeLike May 10, 2024
@guidari guidari added this pull request to the merge queue May 13, 2024
Merged via the queue into carbon-design-system:main with commit 7171531 May 13, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
3 participants