Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(multiselect): restrict readonly storybook control to playground #16316

Merged
merged 2 commits into from May 13, 2024
Merged

docs(multiselect): restrict readonly storybook control to playground #16316

merged 2 commits into from May 13, 2024

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented May 3, 2024 •
edited

Changelog

Removed

  • remove the readOnly entry from the component-level argTypes for Multiselect

Testing / Reviewing

  • The readonly control should only be available for MultiSelect's Playground story. For all other multiselect stories it should be listed but not operable.

Thanks @Kritvi-bhatia17 for pointing this out!

@tay1orjones tay1orjones requested a review from a team as a code owner May 3, 2024 13:21
@netlify Netlify
Copy link

netlify bot commented May 3, 2024 •
edited

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5a8a43e
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6641ef8460b84f00081754d4
😎 Deploy Preview https://deploy-preview-16316--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Kritvi-bhatia17 Kritvi-bhatia17 self-requested a review May 6, 2024 11:07
Kritvi-bhatia17
Kritvi-bhatia17 approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quickly fixing it @tay1orjones ⚡️

LGTM!

@tay1orjones tay1orjones requested a review from a team as a code owner May 13, 2024 10:46
@alisonjoseph alisonjoseph added this pull request to the merge queue May 13, 2024
Merged via the queue into carbon-design-system:main with commit e84ae33 May 13, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@guidari guidari guidari approved these changes

@Kritvi-bhatia17 Kritvi-bhatia17 Kritvi-bhatia17 approved these changes

@tw15egan tw15egan Awaiting requested review from tw15egan tw15egan was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: one more review 👀 status: ready for review 👀 status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tay1orjones @alisonjoseph @guidari @Kritvi-bhatia17 @2nikhiltom