chore: retrieve google sa in batch job only if it's specified #653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deadlycoconuts
approved these changes
Jul 3, 2025
Contributor
deadlycoconuts
left a comment
deadlycoconuts
left a comment
There was a problem hiding this comment.
Thanks a lot for the quick fix! LGTM! 🚀
Contributor
Author
|
@deadlycoconuts and thank you for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the batch-job in Merlin was using BQ table and when client tries to submit a batch-job, Merlin assumed that a Google Service Account will be provided in the job configuration. But as we have added option for using MaxCompute and it doesn't need a Google SA, I'm adding a check where it will only try to retrieve the service account if it's provided
Modifications
Tests
Checklist
Release Notes