MAINT: moving Selection type, IDSelection formats to q2-types #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizgehret
changed the title
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| import qiime2 | |||
|
|
|||
| from genome_sampler.common import IDSelection | |||
| from q2_types._format import IDSelection | |||
There was a problem hiding this comment.
We should avoid importing from _format as the _ files are private by convention (so no guarantee that this import will continue to work in the future).
Update: we should be able to get this from q2_types.feature_data
| @@ -27,13 +26,10 @@ | |||
| AlignedSequence, | |||
| ) | |||
|
|
|||
| from q2_types._type import Selection | |||
There was a problem hiding this comment.
Same comment as above re: importing from files starting with _.
|
We're not going to move forward with this transition right now, as discussed in the linked PR. We may circle back to this in the future, so we're leaving this as a draft PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is paired with another in q2-types, which moves over the following semantic type, formats, and associated transformers:
File/directory formats:
UNIXListFormatIDSelectionIDSelectionDirectoryFormatIDMetadataFormatSemantic Type:
FeatureData[Selection]