Skip to content

fix for categorical columns in Pandas and tests for Polars #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

fdosani
Copy link
Member

@fdosani fdosani commented Mar 14, 2025

fix #391
fix #389

  • I've made some changes to the Pandas logic where we just try and convert to strings and compare instead of checking "string[python]", "string[pyarrow]"
  • Also added some tests for Polars since categoricals exist there.

@epizut and @hanying528 if you have some time to check on your end with this branch it would be much appreciated.

Copy link
Contributor

@gladysteh99 gladysteh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Contributor

@rhaffar rhaffar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fdosani fdosani merged commit 0acdead into develop Mar 14, 2025
39 checks passed
@fdosani fdosani deleted the categorical-pandas-fix branch March 14, 2025 19:28
@fdosani fdosani mentioned this pull request Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants