Merge pull request #411 from Fjan/restore-userdir-relative-path

Restore ability to work with a relative path outside a `within` block
capistrano · Nov 18, 2017 · 158c286 · 158c286
2 parents 05a4322 + abfb3d6
commit 158c286
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@ appear at the top.
 
   * Your contribution here!
   * [#410](https://github.com/capistrano/sshkit/pull/410): call #to_s on remote so Pathnames don't go :boom: - [@UnderpantsGnome](https://github.com/UnderpantsGnome)
+  * [#411](https://github.com/capistrano/sshkit/pull/410): fix upload!/download! relative to user dir that broke in #408 -  [@Fjan](https://github.com/Fjan)
 
 ## [1.15.0][] (2017-11-03)
 

diff --git a/lib/sshkit/backends/local.rb b/lib/sshkit/backends/local.rb
@@ -11,7 +11,7 @@ def initialize(_ = nil, &block)
       end
 
       def upload!(local, remote, options = {})
-        remote = File.join(pwd_path, remote) unless remote.to_s.start_with?("/")
+        remote = File.join(pwd_path, remote) unless remote.to_s.start_with?("/") || pwd_path.nil?
         if local.is_a?(String)
           if options[:recursive]
             FileUtils.cp_r(local, remote)
@@ -26,7 +26,7 @@ def upload!(local, remote, options = {})
       end
 
       def download!(remote, local=nil, _options = {})
-        remote = File.join(pwd_path, remote) unless remote.to_s.start_with?("/")
+        remote = File.join(pwd_path, remote) unless remote.to_s.start_with?("/") || pwd_path.nil?
         if local.nil?
           FileUtils.cp(remote, File.basename(remote))
         else

diff --git a/lib/sshkit/backends/netssh.rb b/lib/sshkit/backends/netssh.rb
@@ -63,15 +63,15 @@ def assign_defaults
 
       def upload!(local, remote, options = {})
         summarizer = transfer_summarizer('Uploading', options)
-        remote = File.join(pwd_path, remote) unless remote.to_s.start_with?("/")
+        remote = File.join(pwd_path, remote) unless remote.to_s.start_with?("/") || pwd_path.nil?
         with_ssh do |ssh|
           ssh.scp.upload!(local, remote, options, &summarizer)
         end
       end
 
       def download!(remote, local=nil, options = {})
         summarizer = transfer_summarizer('Downloading', options)
-        remote = File.join(pwd_path, remote) unless remote.to_s.start_with?("/")
+        remote = File.join(pwd_path, remote) unless remote.to_s.start_with?("/") || pwd_path.nil?
         with_ssh do |ssh|
           ssh.scp.download!(remote, local, options, &summarizer)
         end