Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RuboCop in CI #2148

Merged
merged 1 commit into from Jan 23, 2024
Merged

Fix RuboCop in CI #2148

merged 1 commit into from Jan 23, 2024

Conversation

mattbrictson
Copy link
Member

RuboCop in CI is now running on Ruby 3.3.0. This version no longer includes racc as a default gem, so the old version of RuboCop that we are using fails with this error:

LoadError: cannot load such file -- racc/parser (LoadError)

Fix by explicitly adding racc to our Gemfile.

I also added the base64 gem to address a deprecation warning.

RuboCop in CI is now running on Ruby 3.3.0. This version no longer
includes `racc` as a default gem, so the old version of RuboCop that we
are using fails with this error:

> LoadError: cannot load such file -- racc/parser (LoadError)

Fix by explicitly adding `racc` to our Gemfile.

I also added the `base64` gem to address a deprecation warning.
@mattbrictson mattbrictson added the 🏠 Housekeeping Non-user facing cleanup and maintenance label Jan 15, 2024
@mattbrictson
Copy link
Member Author

Unrelated to this PR, the feature specs are failing due to problems with VirtualBox being unreliable on the latest GitHub Actions runners. I don't think it should block merging this PR.

@mattbrictson mattbrictson merged commit 1e36f5d into master Jan 23, 2024
16 of 17 checks passed
@mattbrictson mattbrictson deleted the fix-rubocop-ci branch January 23, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏠 Housekeeping Non-user facing cleanup and maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant