Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/extend authentication to support id token change #751

Merged
merged 16 commits into from
Nov 7, 2024
Merged

Feat/extend authentication to support id token change #751

merged 16 commits into from
Nov 7, 2024

Conversation

ebarooni
Copy link
Contributor

@ebarooni ebarooni commented Nov 6, 2024 •
edited by robingenz
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.
  • A changeset has been created (npm run changeset).
  • I have read and followed the pull request guidelines.

Close #710
Close #709

ebarooni added 12 commits November 4, 2024 22:42
@ebarooni
feat: extend authentication to support id token change event (#710)
383aef8 
* adds type definitions
@ebarooni
feat: extend authentication to support id token change event (#710)
7c731aa 
* implements idTokenChange on the web
@ebarooni
feat: extend authentication to support id token change event (#710)
edb122b 
* refactors handling id token change in separate method on the web
@ebarooni
feat: extend authentication to support id token change event (#710)
cd182a7 
* implements idTokenChange on ios
@ebarooni
feat: extend authentication to support id token change event (#710)
491d76a 
* implements idTokenChange on android
@ebarooni
feat: extend authentication to support id token change event (#710)
64440d4 
* ios pod install
@ebarooni
feat: extend authentication to support id token change event (#710)
c3915d5 
* replaces user with an object with token property
@ebarooni
feat: extend authentication to support id token change event (#710)
c22b878 
* removes IdTokenChange interface
@ebarooni
feat: extend authentication to support id token change event (#710)
43c1fe4 
* refactors handleIdTokenChange on the web
@ebarooni
feat: extend authentication to support id token change event (#710)
e66ca4d 
* refactors handleIdTokenChange on ios and android
@ebarooni
feat: extend authentication to support id token change event (#710)
13d3cb8 
* removes todos
@ebarooni
feat: extend authentication to support id token change event (#710)
48d49ac 
* adds changeset
@ebarooni ebarooni self-assigned this Nov 6, 2024
@ebarooni ebarooni linked an issue Nov 6, 2024 that may be closed by this pull request
feat: extend authentication to expose the idTokenChange event #710
Closed
13 tasks
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 7, 2024 •
edited
Loading

Open in Stackblitz

@capacitor-firebase/analytics

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/analytics@751

@capacitor-firebase/app

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/app@751

@capacitor-firebase/app-check

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/app-check@751

@capacitor-firebase/authentication

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/authentication@751

@capacitor-firebase/crashlytics

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/crashlytics@751

@capacitor-firebase/firestore

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/firestore@751

@capacitor-firebase/functions

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/functions@751

@capacitor-firebase/messaging

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/messaging@751

@capacitor-firebase/performance

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/performance@751

@capacitor-firebase/remote-config

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/remote-config@751

@capacitor-firebase/storage

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/storage@751

commit: c7f90cf

@ebarooni ebarooni requested a review from robingenz November 7, 2024 08:59
robingenz
robingenz requested changes Nov 7, 2024
View reviewed changes
.changeset/chilled-pumpkins-kick.md Outdated Show resolved Hide resolved
.changeset/chilled-pumpkins-kick.md Outdated Show resolved Hide resolved
packages/authentication/ios/Plugin/FirebaseAuthenticationPlugin.swift Outdated Show resolved Hide resolved
.../io/capawesome/capacitorjs/plugins/firebase/authentication/FirebaseAuthenticationPlugin.java Outdated Show resolved Hide resolved
packages/authentication/src/definitions.ts Outdated Show resolved Hide resolved
packages/authentication/src/definitions.ts Outdated Show resolved Hide resolved
packages/authentication/src/definitions.ts Show resolved Hide resolved
packages/authentication/src/definitions.ts Outdated Show resolved Hide resolved
packages/authentication/src/definitions.ts Outdated Show resolved Hide resolved
packages/authentication/src/web.ts Outdated Show resolved Hide resolved
@ebarooni ebarooni requested a review from robingenz November 7, 2024 20:24
robingenz
robingenz approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@robingenz robingenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you!

@robingenz robingenz merged commit b57f1ee into main Nov 7, 2024
4 checks passed
@robingenz robingenz deleted the feat/extend-authentication-to-support-id-token-change branch November 7, 2024 21:13
@github-actions github-actions bot mentioned this pull request Nov 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robingenz robingenz robingenz approved these changes

Assignees

@ebarooni ebarooni

Labels
feature Feature package: authentication platform: android Android platform platform: ios iOS platform platform: web Web platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: extend authentication to expose the idTokenChange event
2 participants
@ebarooni @robingenz