Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore): timestamp values #557

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix(firestore): timestamp values #557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba17231
wip: ios
robingenz Feb 14, 2024
8d73551
wip: ios
robingenz Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/firestore/ios/Plugin/FirebaseFirestoreHelper.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ public class FirebaseFirestoreHelper {
guard let value = value else {
return nil
}
if let value = value as? Timestamp {
return value.dateValue()
}
guard let value = JSTypes.coerceDictionaryToJSObject(["key": value]) as JSObject? else {
return nil
}
Expand Down
1 change: 1 addition & 0 deletions packages/firestore/ios/Plugin/FirebaseFirestorePlugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ public class FirebaseFirestorePlugin: CAPPlugin {
private var pluginCallMap: [String: CAPPluginCall] = [:]

override public func load() {
self.shouldStringifyDatesInCalls = false
self.implementation = FirebaseFirestore(plugin: self)
}

Expand Down
Loading