Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpoadFileOptions -> UploadFileOptionsWithMetadata #508

Closed
wants to merge 2 commits into from

Conversation

triyam
Copy link

@triyam triyam commented Dec 6, 2023

PR #506

changes in definitions.ts

// ... (other methods)

- options: UploadFileOptionsWithMetadata, // Line: 38
+ options: options: UploadFileOptionsWithMetadata, // Line: 40

// ... (other methods)

+ export interface UploadFileOptionsWithMetadata extends UploadFileOptions {   // Line: 329
+ metadata?: {
+   cacheControl?: string | undefined; 
+    contentDisposition?: string | undefined;
+    contentEncoding?: string | undefined;
+    contentLanguage?: string | undefined;
+    contentType?: string | undefined;
+    customMetadata?: { [key: string]: string } | undefined;
+  };
+ }

// ... (other methods)

@robingenz
Copy link
Member

See #505 (comment)

@robingenz robingenz closed this Dec 7, 2023
@triyam triyam deleted the feat/issue-506 branch December 7, 2023 19:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants