Issue #474

[Paganiniana]

Salutations and hello, all!

This PR is related to issue #474, reported, yesterday. This is my current workaround that I'm using to continue to make use of the project. It all comes down to using a simple serialized format for Google's Timestamp type, re-initializing it whenever it passes between the web and the native layers, but it probably shouldn't be merged as is. This is my first contribution to CapAwesome and I'm still getting the lay of the land (what's more, my Swift is pretty weak). To constitute a full solution, I'm imagining something as follows....

1. Recursively check child JSObjects for Timestamp types and convert as needed (this commit is only a superficial check).

I'm imagining that this would involve the following:

1. Creating a local extension of JSType that includes Timestamp as a potential value
2. Moving the serialization logic somewhere else

@robingenz, I should have more time this weekend to work on my Swift-ese and create a more elegant solution on the iOS side. I could probably figure out the Android side, too, but I don't particularly want to. 😅

[robingenz]

Thank you! I really like your proposed solution. I will take over from here and work on an Android implementation as well. Probably this solution will help me with #443 as well, but it will take me a few weeks as I have other priorities at the moment. I'll keep you updated!

[Paganiniana]

Thanks for getting on this so fast, @robingenz — you're a gem. 👏 I'll have time to help flesh out the iOS side if you like. I actually just made a push to fix the "check recursive" bug, so it should convert timestamps at all layers, now.

[robingenz]

BTW: The Firebase JavaScript SDK should remain an optional dependency on Android and iOS. I will therefore replace the imported Timestamp of the Firebase JavaScript SDK in the final implementation.

[Paganiniana]

BTW: The Firebase JavaScript SDK should remain an optional dependency on Android and iOS. I will therefore replace the imported Timestamp of the Firebase JavaScript SDK in the final implementation.

That makes total sense — I wound up having to avoid it here, anyway, because the class name seemed to get clobbered by various build tools. (Passing a Timestamp from my web app did not get recognized as an instanceof Timestamp at the plugin layer). I started fingerprinting it by the nanoseconds property — not super thorough.

[robingenz]

I close this for #557.