fix(analytics): setUserId accepts null values (#757)

* fix(analytics): setUserId accepts null values * Add changeset * Update .changeset/smooth-mirrors-bow.md --------- Co-authored-by: Robin Genz <[email protected]>
capawesome-team · Nov 19, 2024 · 610a4a1 · 610a4a1
1 parent b57f1ee
commit 610a4a1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/smooth-mirrors-bow.md b/.changeset/smooth-mirrors-bow.md
@@ -0,0 +1,5 @@
+---
+'@capacitor-firebase/analytics': patch
+---
+
+fix(web): `setUserId(...)` has set an empty string instead of `null`
diff --git a/packages/analytics/src/web.ts b/packages/analytics/src/web.ts
@@ -60,7 +60,7 @@ export class FirebaseAnalyticsWeb
 
   public async setUserId(options: SetUserIdOptions): Promise<void> {
     const analytics = getAnalytics();
-    setUserId(analytics, options.userId || '');
+    setUserId(analytics, options.userId);
   }
 
   public async setUserProperty(options: SetUserPropertyOptions): Promise<void> {