Skip to content

Add example for selecting from view with parameters#839

Merged
stewsk merged 5 commits into
mainfrom
view-parameters
Nov 15, 2024
Merged

Add example for selecting from view with parameters#839
stewsk merged 5 commits into
mainfrom
view-parameters

Conversation

@stewsk
Copy link
Copy Markdown
Contributor

@stewsk stewsk commented Apr 16, 2024

No description provided.

Comment thread cds/cdl.md
@stewsk
Copy link
Copy Markdown
Contributor Author

stewsk commented Apr 16, 2024

@renejeglinsky : this is the example on using a view with parameters that we talked about yesterday.
I added a TODO where we could link to respective sections of the runtime docu where they show how to do a select on a view with parameters in the runtimes - although I don't know whether such examples do exist

@agoerler @johannes-vogel : do you have docu/examples showing how to select from a view w/ params in the runtimes that we could link here? This was explicitly asked for in a cap issue.

@johannes-vogel
Copy link
Copy Markdown
Contributor

@renejeglinsky : this is the example on using a view with parameters that we talked about yesterday. I added a TODO where we could link to respective sections of the runtime docu where they show how to do a select on a view with parameters in the runtimes - although I don't know whether such examples do exist

@agoerler @johannes-vogel : do you have docu/examples showing how to select from a view w/ params in the runtimes that we could link here? This was explicitly asked for in a cap issue.

We do not have a sample as we do not have a proper API for that. As of now, it's basically a CQN snippet you need to provide SELECT.from({ id: 'ViewWithParams', args: { p1: {val: 1}, p2: {val:2} }).

Comment thread cds/cdl.md
Comment thread cds/cdl.md Outdated
@renejeglinsky
Copy link
Copy Markdown
Contributor

I think I added everything so that you can do another review please.

@renejeglinsky renejeglinsky marked this pull request as ready for review November 5, 2024 07:43
@renejeglinsky
Copy link
Copy Markdown
Contributor

Can everyone do another review please?

@renejeglinsky
Copy link
Copy Markdown
Contributor

@johannes-vogel Is this fine for you?

@stewsk stewsk merged commit 32147e1 into main Nov 15, 2024
@stewsk stewsk deleted the view-parameters branch November 15, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants