Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Community Toolkit's ObservableValidator as the base class for Screen #397

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Use Community Toolkit's ObservableValidator as the base class for Screen #397

wants to merge 1 commit into from

Conversation

alexhelms
Copy link

  • Screen derives from ObservableValidator.
  • Replace SetAndNotify with SetProperty.
  • Remove PropertyChangedDispatcher.
  • Remove PropertyChangedBase and use ObservableObject in its place.
  • Remove ValidatingModelBase.
  • Remove IValidationAdapter.
  • Remove IModelValidator.
  • Fix up tests.
  • Remove .NET 4.5.2, dotnet 3.0, and dotnet 3.1 target frameworks.
  • Add .NET 4.6.2, dotnet 6, and dotnet 8 target frameworks required for Community Toolkit.

See #396 for discussion.

Use Community Toolkit's ObservableValidator as the base class for Scr…
6b68a70 
…een.

- Screen derives from ObservableValidator.
- Replace SetAndNotify with SetProperty.
- Remove PropertyChangedDispatcher.
- Remove PropertyChangedBase and use ObservableObject in its place.
- Remove ValidatingModelBase.
- Remove IValidationAdapter.
- Remove IModelValidator.
- Fix up tests.
- Remove .NET 4.5.2, dotnet 3.0, and dotnet 3.1 target frameworks.
- Add .NET 4.6.2, dotnet 6, and dotnet 8 target frameworks required for Community Toolkit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alexhelms