Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify variant handling between client and server #1483

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mwhudson
Copy link
Collaborator

No description provided.

@mwhudson
Copy link
Collaborator Author

mwhudson commented Nov 14, 2022

Hmm actually maybe the real point here is that app.variant and source.variant are different things? Maybe app.variant should be app.client_variant? To indicate the nature of the client that is connected? Argh.

@dbungert
Copy link
Collaborator

My long-term goal with all of this might be summarized as - if we had a install-sources.yaml where some entries were 'server' and some where 'desktop', would we handle it appropriately?

Otherwise you end up in this situation where GET /meta/client_variant
returns a different value to the variant you'd get from GET /source, and
that's just confusing. One way this confusion shows up is that if the
default source in the catalog is not server it is not selected, because
some slightly confusing client-server interactions end up setting the
entry on the source model to one of the synthesized ones.

Perhaps these don't need to be two separate attributes, but I think
system_setup depends on app.variant so leave that bit for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants