interfaces/builtin/hostname_control.go: fix call to hostnamectl in core24 #15196
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re24 Since systemd/systemd#27573 we need to allow binding on the client side of the dbus socket. Also hostnamectl seems to need to read properties on /org/freedesktop/systemd1 which should be fine. To reproduce the issue, try to call `hostnamectl` from a snap on Ubuntu Core 24.
Meulengracht
added
the
Needs security review
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15196 +/- ##
==========================================
- Coverage 78.09% 78.08% -0.02%
==========================================
Files 1190 1194 +4
Lines 158458 158585 +127
==========================================
+ Hits 123746 123825 +79
- Misses 27017 27059 +42
- Partials 7695 7701 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bboozzoo
approved these changes
Mar 12, 2025
| @@ -65,6 +71,9 @@ dbus(receive, send) | |||
| interface=org.freedesktop.hostname1 | |||
| member=Set{,Pretty,Static}Hostname, | |||
|
|
|||
| # hostnamectl needs to bind the client side of the socket | |||
| unix (bind) type=stream addr="@*/bus/hostnamectl/system", | |||
There was a problem hiding this comment.
for those left wondering:
$ strace -vf -e bind,connect,socket,recvmsg,sendmsg hostnamectl
socket(AF_UNIX, SOCK_STREAM|SOCK_CLOEXEC|SOCK_NONBLOCK, 0) = 3
bind(3, {sa_family=AF_UNIX, sun_path=@"8ad6795a6c6318c/bus/hostnamectl/system"}, 41) = 0
connect(3, {sa_family=AF_UNIX, sun_path="/run/dbus/system_bus_socket"}, 30) = 0
|
Fri Mar 14 08:10:05 UTC 2025 Failures:Executing:
Restoring:
|
Meulengracht
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since systemd/systemd#27573 we need to allow binding on the client side of the dbus socket.
Also hostnamectl seems to need to read properties on /org/freedesktop/systemd1 which should be fine.
To reproduce the issue, try to call
hostnamectlfrom a snap on Ubuntu Core 24.