Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interfaces/builtin/log_observe.go: add missing udev rule #15194

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

valentindavid
Copy link
Contributor

No description provided.

@valentindavid valentindavid added the Simple 😃 A small PR which can be reviewed quickly label Mar 12, 2025
@valentindavid valentindavid force-pushed the valentindavid/log-observe-missing-udev branch from 5f3debd to 252fcbb Compare March 12, 2025 09:44
Copy link

github-actions bot commented Mar 12, 2025

Thu Mar 13 10:35:32 UTC 2025
The following results are from: https://github.com/canonical/snapd/actions/runs/13808297730

Failures:

Preparing:

  • openstack:debian-12-64:tests/main/xdg-open

Executing:

  • openstack:debian-12-64:tests/main/system-usernames:snap_daemon
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-serial-port
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-required-or-optional
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups:kmsg
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-self-manage
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-strict-enforced
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-helper
  • google:ubuntu-25.04-64:tests/main/snap-user-service-socket-activation
  • google:ubuntu-25.04-64:tests/main/cgroup-devices-v2
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups:uinput
  • google:ubuntu-25.04-64:tests/main/snap-ns-forward-compat
  • google:ubuntu-25.04-64:tests/main/microk8s-smoke:edge

Restoring:

  • openstack:debian-sid-64:tests/main/interfaces-timeserver-control
  • openstack:debian-sid-64:tests/main/debug-migrate-home
  • openstack:debian-12-64:tests/main/snap-run-alias:testsnapdtoolscat
  • openstack:debian-sid-64:tests/main/snap-run
  • openstack:debian-sid-64:tests/main/
  • openstack:debian-sid-64
  • openstack:debian-12-64:tests/main/
  • openstack:debian-12-64
  • openstack:debian-12-64:tests/main/system-usernames:snap_daemon
  • openstack:debian-12-64:tests/main/
  • openstack:debian-12-64
  • openstack:debian-sid-64:tests/main/
  • openstack:debian-sid-64
  • openstack:debian-12-64:tests/main/xdg-open
  • openstack:debian-12-64:tests/main/
  • openstack:debian-12-64
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-strict-enforced

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.14%. Comparing base (d6d95f0) to head (252fcbb).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #15194      +/-   ##
==========================================
+ Coverage   78.09%   78.14%   +0.04%     
==========================================
  Files        1190     1179      -11     
  Lines      158458   158279     -179     
==========================================
- Hits       123746   123684      -62     
+ Misses      27017    26908     -109     
+ Partials     7695     7687       -8     
Flag Coverage Δ
unittests 78.14% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Meulengracht Meulengracht added the Needs security review Can only be merged once security gave a :+1: label Mar 12, 2025
Copy link
Member

@olivercalder olivercalder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zyga zyga requested a review from jslarraz March 13, 2025 08:28
Copy link
Contributor

@zyga zyga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For other reviewers, this grants access to /dev/kmsg:

Excerpt from udevadm info --tree:

├─/devices/virtual/mem/kmsg
│ ┆ P: /devices/virtual/mem/kmsg
│ ┆ M: kmsg
│ ┆ U: mem
│ ┆ D: c 1:11
│ ┆ N: kmsg
│ ┆ L: 0
│ ┆ E: DEVPATH=/devices/virtual/mem/kmsg
│ ┆ E: SUBSYSTEM=mem
│ ┆ E: DEVNAME=/dev/kmsg
│ ┆ E: DEVMODE=0644
│ ┆ E: MAJOR=1
│ ┆ E: MINOR=11

Copy link
Contributor

@jslarraz jslarraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, unless I'm missing something this change is needed by the log_observe interface to serve its expected purpose

Copy link
Collaborator

@pedronis pedronis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs security review Can only be merged once security gave a :+1: Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants