-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interfaces/builtin/log_observe.go: add missing udev rule #15194
base: master
Are you sure you want to change the base?
interfaces/builtin/log_observe.go: add missing udev rule #15194
Conversation
5f3debd
to
252fcbb
Compare
Thu Mar 13 10:35:32 UTC 2025 Failures:Preparing:
Executing:
Restoring:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15194 +/- ##
==========================================
+ Coverage 78.09% 78.14% +0.04%
==========================================
Files 1190 1179 -11
Lines 158458 158279 -179
==========================================
- Hits 123746 123684 -62
+ Misses 27017 26908 -109
+ Partials 7695 7687 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For other reviewers, this grants access to /dev/kmsg
:
Excerpt from udevadm info --tree
:
├─/devices/virtual/mem/kmsg
│ ┆ P: /devices/virtual/mem/kmsg
│ ┆ M: kmsg
│ ┆ U: mem
│ ┆ D: c 1:11
│ ┆ N: kmsg
│ ┆ L: 0
│ ┆ E: DEVPATH=/devices/virtual/mem/kmsg
│ ┆ E: SUBSYSTEM=mem
│ ┆ E: DEVNAME=/dev/kmsg
│ ┆ E: DEVMODE=0644
│ ┆ E: MAJOR=1
│ ┆ E: MINOR=11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, unless I'm missing something this change is needed by the log_observe interface to serve its expected purpose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
No description provided.