Skip to content

[ci] Fix description of custom checkout action #3996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2025
Merged

[ci] Fix description of custom checkout action #3996

merged 1 commit into from
Apr 5, 2025

Conversation

ricab
Copy link
Collaborator

@ricab ricab commented Mar 21, 2025

The action claimed it checked out Multipass code, but that is actually
done elsewhere via the standard GitHub "checkout" action.

The action claimed it checked out Multipass code, but that is actually
done elsewhere via the standard GitHub "checkout" action.
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.44%. Comparing base (f7ba74f) to head (a3ef9e4).
Report is 183 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3996      +/-   ##
==========================================
+ Coverage   89.27%   89.44%   +0.17%     
==========================================
  Files         259      260       +1     
  Lines       14653    14999     +346     
==========================================
+ Hits        13081    13416     +335     
- Misses       1572     1583      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ricab
Copy link
Collaborator Author

ricab commented Apr 4, 2025

I don't have any further fixes at this point, so may as well merge.

@ricab ricab marked this pull request as ready for review April 4, 2025 11:21
@ricab ricab requested review from Copilot and Sploder12 April 4, 2025 11:21
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

.github/actions/checkout/action.yml:2

  • Consider explicitly mentioning that the checkout of the Multipass code is handled by the standard GitHub checkout action to avoid any confusion.
description: Get tags and submodules for the Multipass repository

@ricab ricab requested a review from georgeliao April 4, 2025 11:21
Copy link
Contributor

@Sploder12 Sploder12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's more accurate!

@ricab ricab requested review from Sploder12 and sharder996 and removed request for Sploder12 and georgeliao April 4, 2025 15:50
@sharder996 sharder996 added this pull request to the merge queue Apr 4, 2025
Merged via the queue into main with commit 7cb6b2b Apr 5, 2025
24 checks passed
@sharder996 sharder996 deleted the ci-fixes branch April 5, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants